Open
Conversation
…sw/week8 [feat] created week8 cra
…main [feat] created footer and few css works
…act into week9/solution
whwoohw
reviewed
May 30, 2023
whwoohw
left a comment
whwoohw
left a comment
There was a problem hiding this comment.
굳 깔끔하게 잘 작성해준 것 같습니다!
간단한 궁금중들 몇개 적어뒀습니다. 수정하고 싶으시면 수정하고 merge까지 해주세요!
Comment on lines
+39
to
+45
| setFormData((prevFormData) => ({ | ||
| ...prevFormData, | ||
| username: user.username, | ||
| email: userprofile.user.email, | ||
| major: userprofile.major, | ||
| college: userprofile.college, | ||
| })); |
Comment on lines
+28
to
+34
| useEffect(() => { | ||
| const getUserAPI = async () => { | ||
| const user = await getUser(); | ||
| setUser(user); | ||
| }; | ||
| getUserAPI(); | ||
| }, []); |
There was a problem hiding this comment.
사실 getUserProfileAPI에 필요한 정보는 다 올텐데, 굳이 비슷한 api를 2번 호출하는건 비효율적이겠죠?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.